Fork me on GitHub
a Sensio Labs Product

15 Keys Accelerate (v3.54.0) edition

Rule no_break_comment

There must be a comment when fall-through is intentional in a non-empty case body.

Description

Adds a “no break” comment before fall-through cases, and removes it if there is no fall-through.

Configuration

comment_text

The text to use in the added comment and to detect it.

Allowed types: string

Default value: 'no break'

Examples

Example #1

Default configuration.

--- Original
+++ New
 <?php
 switch ($foo) {
     case 1:
         foo();
+        // no break
     case 2:
         bar();
-        // no break
         break;
     case 3:
         baz();
 }

Example #2

With configuration: ['comment_text' => 'some comment'].

--- Original
+++ New
 <?php
 switch ($foo) {
     case 1:
         foo();
+        // some comment
     case 2:
         foo();
 }

Rule sets

The rule is part of the following rule sets:

References

The test class defines officially supported behaviour. Each test case is a part of our backward compatibility promise.